Initiate community driven fork #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shishir Mahajan <[email protected]>
This version of Go is later overridden in `tests/run_tests.sh`: https://github.com/Roblox/nomad-driver-containerd/blob/80b9be1353f701b9d47d874923a9e8ffed4dbd98/tests/run_tests.sh#L128-L132
https://go.dev/wiki/CodeReviewComments#error-strings > Error strings should not be capitalized (unless beginning with proper nouns or acronyms) or end with punctuation, since they are usually printed following other context.
olljanat
force-pushed
the
create-fork
branch
from
1240a71 to
af22d87
Compare
olljanat
force-pushed
the
create-fork
branch
5 times, most recently
from
aafdaf9 to
8654f7a
Compare
Without this, `vagrant up` fails on Windows:
containerd-linux: /tmp/vagrant-shell: ./setup.sh: /bin/bash^M: bad interpreter: No such file or directory
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.
* Fix release badge * Fix typos * Enable syntax highlighting * etc
Depending on the workload, the default resource limit (ulimit) for the max number of file descriptors per process may need to be raised, such as for database servers. Add a `file_limit` option to the task config which will allow the limit to be set per task. Signed-off-by: Ryan Sundberg <[email protected]>
Signed-off-by: Olli Janatuinen <[email protected]>
olljanat
force-pushed
the
create-fork
branch
from
9468414 to
85dd3ac
Compare
Signed-off-by: Olli Janatuinen <[email protected]>
olljanat
force-pushed
the
create-fork
branch
from
85dd3ac to
0edd906
Compare
olljanat
force-pushed
the
create-fork
branch
2 times, most recently
from
55e939c to
c90db02
Compare
olljanat
force-pushed
the
create-fork
branch
from
c90db02 to
4b6ba92
Compare
Member
Author
|
Seems passing CI now so will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Roblox#167 (comment) looks that Roblox does not use this project anymore so this PR will initiate new fork by including following PRs:
* Make containerd socket path configurable Roblox/nomad-driver-containerd#172file_limitto set RLIMIT_NOFILE Roblox/nomad-driver-containerd#180Update Go version and packages to latest versions.
Add initial support for Roblox#131 by allowing Windows builds.
CI still needs more work but this can be tested with binaries from v0.9.5-beta1